Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify otel limits #1746

Closed
wants to merge 1 commit into from
Closed

Simplify otel limits #1746

wants to merge 1 commit into from

Conversation

fractalwrench
Copy link
Contributor

Goal

Simplifies the limits enforced on OTel data capture by rolling custom and system attributes + events into one. This should make it simpler for pure OTel folks to send as much data as they want by configuring the SDK appropriately.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner December 5, 2024 11:35
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (f3c3d7f) to head (1d3cd32).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 93.33% 0 Missing and 2 partials ⚠️
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 87.50% 0 Missing and 1 partial ⚠️
...droid/embracesdk/internal/spans/SpanServiceImpl.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   85.31%   85.29%   -0.02%     
==========================================
  Files         464      464              
  Lines       10775    10754      -21     
  Branches     1591     1589       -2     
==========================================
- Hits         9193     9173      -20     
  Misses        870      870              
+ Partials      712      711       -1     
Files with missing lines Coverage Δ
...ternal/capture/session/EmbraceSessionProperties.kt 96.49% <100.00%> (ø)
...nternal/config/instrumented/OtelLimitsConfigExt.kt 100.00% <100.00%> (ø)
...racesdk/internal/opentelemetry/OpenTelemetrySdk.kt 100.00% <100.00%> (ø)
...al/session/orchestrator/SessionOrchestratorImpl.kt 91.81% <100.00%> (ø)
...ssion/orchestrator/SessionSpanAttrPopulatorImpl.kt 93.93% <100.00%> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 78.12% <100.00%> (ø)
...mbracesdk/internal/spans/PersistableEmbraceSpan.kt 100.00% <ø> (ø)
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 90.24% <100.00%> (ø)
...nal/config/instrumented/schema/OtelLimitsConfig.kt 100.00% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 88.75% <87.50%> (ø)
... and 2 more

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we separated system and custom attributes is so we can have a lower limit for custom attributes (e.g. max 10 attributes per span) for customers that send us data.

With this new scheme how are we enforcing those lower limits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants