Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support otel export only flag #1747

Closed
wants to merge 1 commit into from
Closed

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds a new flag to the config with the key sdk_config.otel_export_only. The intention is that customers who don't want to send data to Embrace can set this flag to true, and the SDK will avoid sending any data to Embrace. This also alters what bytecode we instrument (i.e. data limits).

Testing

Added an integration test that confirms this workflow isn't broken.

@fractalwrench fractalwrench requested a review from a team as a code owner December 5, 2024 12:31
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (1d3cd32) to head (c0e99af).

Files with missing lines Patch % Lines
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 55.55% 0 Missing and 4 partials ⚠️
.../embracesdk/internal/injection/ConfigModuleImpl.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           simplify-limits    #1747      +/-   ##
===================================================
+ Coverage            85.29%   85.46%   +0.17%     
===================================================
  Files                  464      464              
  Lines                10754    10756       +2     
  Branches              1589     1588       -1     
===================================================
+ Hits                  9173     9193      +20     
  Misses                 870      870              
+ Partials               711      693      -18     
Files with missing lines Coverage Δ
...id/embracesdk/internal/config/ConfigServiceImpl.kt 96.15% <100.00%> (+0.15%) ⬆️
...config/instrumented/schema/EnabledFeatureConfig.kt 100.00% <100.00%> (ø)
...nal/config/instrumented/schema/OtelLimitsConfig.kt 100.00% <ø> (ø)
.../embracesdk/internal/injection/ConfigModuleImpl.kt 93.18% <75.00%> (+8.73%) ⬆️
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 77.14% <55.55%> (+0.21%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants