Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto termination propagation #1749

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix auto termination propagation #1749

merged 1 commit into from
Dec 9, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Fixes a few places where the AutoTermination enum wasn't getting passed through. I also removed it as a parameter from recordCompletedSpan as it doesn't make sense in the context of that function. I debated removing it from recordSpan but believe it makes sense to keep it there given that the code block could potentially run for a long time.

Testing

Relied on existing test coverage. An upcoming PR will include the integration test that originally caught these problems.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (2f8ad69) to head (e7a6db8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../io/embrace/android/embracesdk/spans/TracingApi.kt 44.00% 14 Missing ⚠️
...main/java/io/embrace/android/embracesdk/Embrace.kt 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   85.41%   85.31%   -0.11%     
==========================================
  Files         464      464              
  Lines       10771    10783      +12     
  Branches     1596     1596              
==========================================
- Hits         9200     9199       -1     
- Misses        857      870      +13     
  Partials      714      714              
Files with missing lines Coverage Δ
...android/embracesdk/internal/spans/EmbraceTracer.kt 100.00% <ø> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt 82.27% <80.00%> (ø)
.../io/embrace/android/embracesdk/spans/TracingApi.kt 77.92% <44.00%> (-15.83%) ⬇️

Base automatically changed from add-auto-term-enum to main December 6, 2024 17:36
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@fractalwrench fractalwrench merged commit 9b5b93e into main Dec 9, 2024
7 checks passed
@fractalwrench fractalwrench deleted the auto-term-param branch December 9, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants