Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes a few places where the
AutoTermination
enum wasn't getting passed through. I also removed it as a parameter fromrecordCompletedSpan
as it doesn't make sense in the context of that function. I debated removing it fromrecordSpan
but believe it makes sense to keep it there given that the code block could potentially run for a long time.Testing
Relied on existing test coverage. An upcoming PR will include the integration test that originally caught these problems.