Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set internal error logger correctly #1752

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

The internal error logger was set in ModuleInitBootstrapper at a point where it would return false, meaning internal error logs were effectively not sent in 6.13.0. I've fixed this by setting the value via a lambda (as was the case in versions below 6.13.0). I also added the lambda as a property of the logging interface so that it's testable with the fake implementation.

Testing

Added an integration test.

@fractalwrench fractalwrench requested a review from a team as a code owner December 9, 2024 14:56
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.27%. Comparing base (ac235c4) to head (bd9deea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...droid/embracesdk/internal/logging/EmbLoggerImpl.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   85.28%   85.27%   -0.02%     
==========================================
  Files         464      464              
  Lines       10793    10791       -2     
  Branches     1596     1595       -1     
==========================================
- Hits         9205     9202       -3     
+ Misses        871      870       -1     
- Partials      717      719       +2     
Files with missing lines Coverage Δ
...e/android/embracesdk/internal/logging/EmbLogger.kt 66.66% <ø> (ø)
...cesdk/internal/injection/ModuleInitBootstrapper.kt 89.93% <100.00%> (-0.07%) ⬇️
...droid/embracesdk/internal/logging/EmbLoggerImpl.kt 17.64% <50.00%> (ø)

... and 4 files with indirect coverage changes

@fractalwrench fractalwrench force-pushed the fix-internal-error-logging branch from 9ac1f74 to bd9deea Compare December 10, 2024 07:09
@fractalwrench fractalwrench merged commit 56eb868 into main Dec 10, 2024
7 checks passed
@fractalwrench fractalwrench deleted the fix-internal-error-logging branch December 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants