Set internal error logger correctly #1752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The internal error logger was set in
ModuleInitBootstrapper
at a point where it would return false, meaning internal error logs were effectively not sent in 6.13.0. I've fixed this by setting the value via a lambda (as was the case in versions below 6.13.0). I also added the lambda as a property of the logging interface so that it's testable with the fake implementation.Testing
Added an integration test.