Allow all activities to ge traced by default #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 1, 2025
Merged
bidetofevil
force-pushed
the
hho/load-trace-config
branch
from
48d930d to
7bbd8fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
==========================================
- Coverage 85.47% 85.46% -0.01%
==========================================
Files 466 466
Lines 10944 10948 +4
Branches 1626 1626
==========================================
+ Hits 9354 9357 +3
Misses 861 861
- Partials 729 730 +1
|
This was referenced Jan 2, 2025
bidetofevil
requested review from
fractalwrench,
fnewberg and
a team
as code owners
fractalwrench
approved these changes
Jan 6, 2025
...va/io/embrace/android/embracesdk/internal/config/behavior/AutoDataCaptureBehaviorImplTest.kt
Show resolved
Hide resolved
Comment on lines
+178
to
+179
| return javaClass.isAnnotationPresent(TracedActivity::class.java) || | ||
| autoTraceEnabled && !javaClass.isAnnotationPresent(NotTracedActivity::class.java) |
There was a problem hiding this comment.
Does this work with R8 or are additional rules required?
There was a problem hiding this comment.
This should work given that it's how we check @StartupActivity, but I'll double check.
There was a problem hiding this comment.
Nice catch. Looks like this is an issue - which means @startupactivity detection didn't work either at runtime either.
...main/kotlin/io/embrace/android/embracesdk/internal/injection/DataCaptureServiceModuleImpl.kt
Show resolved
Hide resolved
bidetofevil
force-pushed
the
hho/trim-ui-load-events
branch
from
6841bf2 to
5c4591e
Compare
bidetofevil
force-pushed
the
hho/load-trace-config
branch
from
7bbd8fe to
5065414
Compare
bidetofevil
changed the base branch from
hho/trim-ui-load-events
to
graphite-base/1789
bidetofevil
force-pushed
the
hho/load-trace-config
branch
from
5065414 to
cd6536e
Compare
bidetofevil
force-pushed
the
graphite-base/1789
branch
from
5c4591e to
357553b
Compare
bidetofevil
force-pushed
the
hho/load-trace-config
branch
from
cd6536e to
42f2e2b
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
bidetofevil
commented
Jan 6, 2025
| @@ -1,4 +1,4 @@ | |||
| -keepattributes LineNumberTable, SourceFile | |||
| -keepattributes LineNumberTable, SourceFile, RuntimeVisibleAnnotations | |||
There was a problem hiding this comment.
This will minimally make annotations work if it's not specified in another proguard file. We should probably just add all annotations, but we can do that in a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add in annotations that allow a local config to specify that all activities loads are traced, with an opt-out annotation for those that shouldn't be.
Note: a change to the swazzler is needed to properly wire this up, but the SDK changes are all contained and tested in this PR.