Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure assertions to remove magic numbers #1791

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 3, 2025

Goal

Tweaked tests so the timing assertions are more readible.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (c1c937d) to head (85be090).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         467      467           
  Lines       10964    10964           
  Branches     1629     1629           
=======================================
  Hits         9372     9372           
  Misses        861      861           
  Partials      731      731           

see 2 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil requested a review from fnewberg as a code owner January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from a66de26 to fd312e6 Compare January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from fd312e6 to 5a66b7b Compare January 6, 2025 19:53
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 5a66b7b to 708a6ec Compare January 6, 2025 21:17
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 708a6ec to 6ed5939 Compare January 6, 2025 21:22
@bidetofevil bidetofevil force-pushed the hho/manual-end-api branch 2 times, most recently from 0600614 to 59d7670 Compare January 6, 2025 22:38
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch 3 times, most recently from 716ea97 to b26cf54 Compare January 7, 2025 19:10
@bidetofevil bidetofevil force-pushed the hho/manual-end-api branch 4 times, most recently from f9151a2 to 6cfcdda Compare January 7, 2025 19:44
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from b26cf54 to a0154ae Compare January 7, 2025 19:44
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from a0154ae to 1d021e9 Compare January 7, 2025 20:27
Copy link
Collaborator Author

bidetofevil commented Jan 8, 2025

Merge activity

  • Jan 8, 11:04 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 8, 11:06 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 8, 11:21 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/manual-end-api to graphite-base/1791 January 8, 2025 16:04
@bidetofevil bidetofevil changed the base branch from graphite-base/1791 to main January 8, 2025 16:04
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 1d021e9 to 85be090 Compare January 8, 2025 16:05
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit 8048b99 into main Jan 8, 2025
5 of 6 checks passed
@bidetofevil bidetofevil deleted the hho/improve-ui-load-tests branch January 8, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants