-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure assertions to remove magic numbers #1791
Merged
Merged
+49
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 467 467
Lines 10964 10964
Branches 1629 1629
=======================================
Hits 9372 9372
Misses 861 861
Partials 731 731 |
This was referenced Jan 5, 2025
bidetofevil
requested review from
fractalwrench
and removed request for
a team
January 6, 2025 08:29
fractalwrench
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bidetofevil
force-pushed
the
hho/manual-end-api
branch
from
January 6, 2025 16:05
78153d9
to
454b9af
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 16:05
a66de26
to
fd312e6
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
from
January 6, 2025 19:52
454b9af
to
58636dd
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 19:53
fd312e6
to
5a66b7b
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
from
January 6, 2025 21:17
58636dd
to
6ee610c
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 21:17
5a66b7b
to
708a6ec
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
from
January 6, 2025 21:22
6ee610c
to
dd7f138
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 21:22
708a6ec
to
6ed5939
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
2 times, most recently
from
January 6, 2025 22:38
0600614
to
59d7670
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
3 times, most recently
from
January 7, 2025 19:10
716ea97
to
b26cf54
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
4 times, most recently
from
January 7, 2025 19:44
f9151a2
to
6cfcdda
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 19:44
b26cf54
to
a0154ae
Compare
bidetofevil
force-pushed
the
hho/manual-end-api
branch
from
January 7, 2025 20:27
6cfcdda
to
8169c3e
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 20:27
a0154ae
to
1d021e9
Compare
bidetofevil
changed the base branch from
hho/manual-end-api
to
graphite-base/1791
January 8, 2025 16:04
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 8, 2025 16:05
1d021e9
to
85be090
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Tweaked tests so the timing assertions are more readible.