-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract frame draw detection to its own component #1793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2025
Merged
This was referenced Jan 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
+ Coverage 85.44% 85.52% +0.08%
==========================================
Files 467 468 +1
Lines 10964 10965 +1
Branches 1629 1630 +1
==========================================
+ Hits 9368 9378 +10
+ Misses 863 857 -6
+ Partials 733 730 -3
|
This was referenced Jan 6, 2025
bidetofevil
requested review from
fractalwrench
and removed request for
a team
January 6, 2025 08:31
fractalwrench
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 16:05
a66de26
to
fd312e6
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 6, 2025 16:05
9d55875
to
81c9825
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 19:53
fd312e6
to
5a66b7b
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 6, 2025 19:54
81c9825
to
932e35c
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 21:17
5a66b7b
to
708a6ec
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 6, 2025 21:17
932e35c
to
aa5d62f
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 21:22
708a6ec
to
6ed5939
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 6, 2025 21:22
aa5d62f
to
376acad
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 6, 2025 22:38
6ed5939
to
ac7156a
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 6, 2025 22:39
376acad
to
eb153a4
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 18:30
ac7156a
to
716ea97
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 7, 2025 18:30
eb153a4
to
83ae031
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 19:10
716ea97
to
b26cf54
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 7, 2025 19:10
83ae031
to
0c338d0
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 19:44
b26cf54
to
a0154ae
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 7, 2025 19:45
0c338d0
to
677bbeb
Compare
bidetofevil
force-pushed
the
hho/improve-ui-load-tests
branch
from
January 7, 2025 20:27
a0154ae
to
1d021e9
Compare
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 7, 2025 20:27
677bbeb
to
e9db84f
Compare
bidetofevil
changed the base branch from
hho/improve-ui-load-tests
to
graphite-base/1793
January 8, 2025 16:05
bidetofevil
force-pushed
the
hho/extract-draw-detector
branch
from
January 8, 2025 16:22
e9db84f
to
a204c36
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Extract the code to detect when a app startup is ended by the first activity drawing its first frame into its own class so it can be used for the UI Load trace as well.