Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract frame draw detection to its own component #1793

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 5, 2025

Goal

Extract the code to detect when a app startup is ended by the first activity drawing its first frame into its own class so it can be used for the UI Load trace as well.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (8048b99) to head (a204c36).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 26.53% 31 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
+ Coverage   85.44%   85.52%   +0.08%     
==========================================
  Files         467      468       +1     
  Lines       10964    10965       +1     
  Branches     1629     1630       +1     
==========================================
+ Hits         9368     9378      +10     
+ Misses        863      857       -6     
+ Partials      733      730       -3     
Files with missing lines Coverage Δ
...racesdk/internal/capture/startup/StartupTracker.kt 90.24% <100.00%> (+39.69%) ⬆️
...internal/injection/DataCaptureServiceModuleImpl.kt 95.74% <100.00%> (+0.09%) ⬆️
...d/embracesdk/internal/logging/InternalErrorType.kt 100.00% <100.00%> (ø)
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 26.53% <26.53%> (ø)

... and 3 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review January 6, 2025 08:31
@bidetofevil bidetofevil requested a review from a team as a code owner January 6, 2025 08:31
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team January 6, 2025 08:31
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from a66de26 to fd312e6 Compare January 6, 2025 16:05
@bidetofevil bidetofevil requested a review from fnewberg as a code owner January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 9d55875 to 81c9825 Compare January 6, 2025 16:05
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from fd312e6 to 5a66b7b Compare January 6, 2025 19:53
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 81c9825 to 932e35c Compare January 6, 2025 19:54
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 5a66b7b to 708a6ec Compare January 6, 2025 21:17
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 932e35c to aa5d62f Compare January 6, 2025 21:17
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 708a6ec to 6ed5939 Compare January 6, 2025 21:22
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from aa5d62f to 376acad Compare January 6, 2025 21:22
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 6ed5939 to ac7156a Compare January 6, 2025 22:38
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 376acad to eb153a4 Compare January 6, 2025 22:39
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from ac7156a to 716ea97 Compare January 7, 2025 18:30
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from eb153a4 to 83ae031 Compare January 7, 2025 18:30
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from 716ea97 to b26cf54 Compare January 7, 2025 19:10
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 83ae031 to 0c338d0 Compare January 7, 2025 19:10
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from b26cf54 to a0154ae Compare January 7, 2025 19:44
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 0c338d0 to 677bbeb Compare January 7, 2025 19:45
@bidetofevil bidetofevil force-pushed the hho/improve-ui-load-tests branch from a0154ae to 1d021e9 Compare January 7, 2025 20:27
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from 677bbeb to e9db84f Compare January 7, 2025 20:27
Copy link
Collaborator Author

bidetofevil commented Jan 8, 2025

Merge activity

  • Jan 8, 11:04 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 8, 11:23 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 8, 11:34 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/improve-ui-load-tests to graphite-base/1793 January 8, 2025 16:05
@bidetofevil bidetofevil changed the base branch from graphite-base/1793 to main January 8, 2025 16:21
@bidetofevil bidetofevil force-pushed the hho/extract-draw-detector branch from e9db84f to a204c36 Compare January 8, 2025 16:22
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit d1aa94d into main Jan 8, 2025
6 checks passed
@bidetofevil bidetofevil deleted the hho/extract-draw-detector branch January 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants