Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size parameter from user hosted log messages #1821

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the size parameter from user hosted log messages as we will calculate this on the backend & the attribute was unnecessary

Testing

Updated existing tests.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (76f1340) to head (62f5d66).

Files with missing lines Patch % Lines
...embracesdk/internal/logs/attachments/Attachment.kt 87.50% 1 Missing ⚠️
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           embrace-hosted-attachments    #1821      +/-   ##
==============================================================
- Coverage                       85.48%   85.46%   -0.02%     
==============================================================
  Files                             474      474              
  Lines                           11091    11083       -8     
  Branches                         1666     1665       -1     
==============================================================
- Hits                             9481     9472       -9     
  Misses                            869      869              
- Partials                          741      742       +1     
Files with missing lines Coverage Δ
...k/internal/logs/attachments/AttachmentErrorCode.kt 100.00% <ø> (ø)
...sdk/internal/logs/attachments/AttachmentService.kt 100.00% <ø> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt 86.95% <100.00%> (ø)
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 76.79% <ø> (-0.13%) ⬇️
...embracesdk/internal/logs/attachments/Attachment.kt 96.55% <87.50%> (-0.51%) ⬇️
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 86.51% <0.00%> (+1.12%) ⬆️

... and 1 file with indirect coverage changes

Add integration tests for file attachments
@fractalwrench fractalwrench merged commit 244ace1 into embrace-hosted-attachments Jan 17, 2025
2 of 3 checks passed
@fractalwrench fractalwrench deleted the tweak-api branch January 17, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants