Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak log attachment implementation after manual testing #1823

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

fractalwrench
Copy link
Contributor

Goal

This changeset contains a few tweaks to the log attachment implementation that were required after carrying out manual testing:

  • Created screen in example app for log messages with attachments
  • Used 'attachments' instead of 'attachment' as endpoint
  • Logged a message if an attachment can't be sent due to limits

@fractalwrench fractalwrench requested a review from a team as a code owner January 16, 2025 15:55
@@ -10,6 +10,6 @@ enum class Endpoint(
LOGS("logs", "v2"),
SESSIONS("spans", "v2"),
CONFIG("config", "v2"),
ATTACHMENT("attachment", "v2"),
ATTACHMENT("attachments", "v2"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also rename the enum type name? ATTACHMENT -> ATTACHMENTS

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (244ace1) to head (eb9e17e).
Report is 3 commits behind head on file-attachment-api.

Files with missing lines Patch % Lines
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           file-attachment-api    #1823      +/-   ##
=======================================================
- Coverage                85.46%   85.46%   -0.01%     
=======================================================
  Files                      474      474              
  Lines                    11083    11094      +11     
  Branches                  1665     1668       +3     
=======================================================
+ Hits                      9472     9481       +9     
- Misses                     869      871       +2     
  Partials                   742      742              
Files with missing lines Coverage Δ
...embracesdk/internal/logs/attachments/Attachment.kt 96.55% <100.00%> (ø)
...racesdk/internal/delivery/SupportedEnvelopeType.kt 100.00% <100.00%> (ø)
...elivery/execution/OkHttpRequestExecutionService.kt 89.70% <100.00%> (ø)
.../android/embracesdk/internal/comms/api/Endpoint.kt 100.00% <100.00%> (ø)
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 84.00% <63.63%> (-2.52%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from extra-test-cases to tweak-api January 17, 2025 07:05
Base automatically changed from tweak-api to embrace-hosted-attachments January 17, 2025 07:05
Base automatically changed from embrace-hosted-attachments to file-attachment-api January 17, 2025 07:05
@fractalwrench fractalwrench merged commit 0cf563c into file-attachment-api Jan 17, 2025
2 of 3 checks passed
@fractalwrench fractalwrench deleted the testing-tweaks branch January 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants