Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate APIs to return the current SDK time #1825

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 16, 2025

Goal

Consolidated private APIs that exposed the SDK time and use the new public API instead.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (58bbf3e) to head (75ef997).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   85.49%   85.49%   -0.01%     
==========================================
  Files         473      473              
  Lines       11048    11046       -2     
  Branches     1652     1652              
==========================================
- Hits         9446     9444       -2     
+ Misses        867      865       -2     
- Partials      735      737       +2     
Files with missing lines Coverage Δ
...esdk/internal/injection/OpenTelemetryModuleImpl.kt 96.92% <100.00%> (ø)
...android/embracesdk/internal/spans/EmbraceTracer.kt 100.00% <ø> (ø)
...ndroid/embracesdk/internal/spans/InternalTracer.kt 95.45% <100.00%> (+0.06%) ⬆️
...dk/okhttp3/EmbraceOkHttp3ApplicationInterceptor.kt 97.82% <100.00%> (ø)
...acesdk/okhttp3/EmbraceOkHttp3NetworkInterceptor.kt 90.97% <100.00%> (ø)
...ernal/api/delegate/EmbraceInternalInterfaceImpl.kt 77.94% <ø> (-0.32%) ⬇️
...nal/network/http/EmbraceUrlConnectionDelegate.java 83.73% <100.00%> (ø)
...dk/internal/network/http/InternalNetworkApiImpl.kt 42.85% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Jan 17, 2025

Merge activity

  • Jan 17, 12:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 17, 12:53 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 17, 1:05 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/custom-startup-trace to graphite-base/1825 January 17, 2025 17:38
@bidetofevil bidetofevil changed the base branch from graphite-base/1825 to main January 17, 2025 17:51
@bidetofevil bidetofevil requested a review from fnewberg as a code owner January 17, 2025 17:51
@bidetofevil bidetofevil force-pushed the hho/consolidate-sdk-time-api branch from f5df002 to 75ef997 Compare January 17, 2025 17:52
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit 4eeb616 into main Jan 17, 2025
5 of 6 checks passed
@bidetofevil bidetofevil deleted the hho/consolidate-sdk-time-api branch January 17, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants