-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate APIs to return the current SDK time #1825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
bidetofevil
force-pushed
the
hho/custom-startup-trace
branch
from
January 17, 2025 06:58
707e582
to
cdbca55
Compare
bidetofevil
force-pushed
the
hho/consolidate-sdk-time-api
branch
from
January 17, 2025 06:58
4de9a79
to
f5df002
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
==========================================
- Coverage 85.49% 85.49% -0.01%
==========================================
Files 473 473
Lines 11048 11046 -2
Branches 1652 1652
==========================================
- Hits 9446 9444 -2
+ Misses 867 865 -2
- Partials 735 737 +2
|
fractalwrench
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bidetofevil
changed the base branch from
hho/custom-startup-trace
to
graphite-base/1825
January 17, 2025 17:38
bidetofevil
force-pushed
the
hho/consolidate-sdk-time-api
branch
from
January 17, 2025 17:52
f5df002
to
75ef997
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Consolidated private APIs that exposed the SDK time and use the new public API instead.