Skip to content

Commit

Permalink
Merge branch 'main' into rc-store-assets-in-github
Browse files Browse the repository at this point in the history
  • Loading branch information
ArielDemarco committed Jul 24, 2024
2 parents 1f886ee + e8e6dd0 commit 2587ed8
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 30 deletions.
32 changes: 32 additions & 0 deletions .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Dependency Review Action
#
# This Action will scan dependency manifest files that change as part of a Pull Request,
# surfacing known-vulnerable versions of the packages declared or updated in the PR.
# Once installed, if the workflow run is marked as required, PRs introducing known-vulnerable
# packages will be blocked from merging.
#
# Source repository: https://github.com/actions/dependency-review-action
# Public documentation: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement
name: Dependency Review
on:
pull_request:
branches: [ "main" ]

permissions:
contents: read
pull-requests: write

jobs:
dependency-review:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Dependency Review
uses: actions/dependency-review-action@v4
# Commonly enabled options, see https://github.com/actions/dependency-review-action#configuration-options for all available options.
with:
comment-summary-in-pr: always
# fail-on-severity: moderate
# deny-licenses: GPL-1.0-or-later, LGPL-2.0-or-later
# retry-on-snapshot-warnings: true
29 changes: 0 additions & 29 deletions .github/workflows/publish.yml

This file was deleted.

6 changes: 5 additions & 1 deletion Sources/EmbraceCore/Session/SessionController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class SessionController: SessionControllable {
weak var storage: EmbraceStorage?
weak var upload: EmbraceUpload?
let heartbeat: SessionHeartbeat
let queue: DispatchQueue

internal var notificationCenter = NotificationCenter.default

Expand All @@ -48,6 +49,7 @@ class SessionController: SessionControllable {

let heartbeatQueue = DispatchQueue(label: "com.embrace.session_heartbeat")
self.heartbeat = SessionHeartbeat(queue: heartbeatQueue, interval: heartbeatInterval)
self.queue = DispatchQueue(label: "com.embrace.session_controller_upload")

self.heartbeat.callback = { [weak self] in
let heartbeat = Date()
Expand Down Expand Up @@ -161,7 +163,9 @@ class SessionController: SessionControllable {
return
}

UnsentDataHandler.sendSession(session, storage: storage, upload: upload)
queue.async {
UnsentDataHandler.sendSession(session, storage: storage, upload: upload)
}
}
}

Expand Down

0 comments on commit 2587ed8

Please sign in to comment.