From 4c3a7d2f40d2f0a0a15b13d7882be0c731a42fdd Mon Sep 17 00:00:00 2001 From: Ignacio Tischelman Date: Wed, 4 Dec 2024 13:43:39 -0300 Subject: [PATCH] Disabling memory termination feature from KSCrash --- .../xcshareddata/swiftpm/Package.resolved | 8 ++++---- .../xcshareddata/swiftpm/Package.resolved | 8 ++++---- Package.resolved | 4 ++-- Package.swift | 2 +- Sources/EmbraceCrash/EmbraceCrashReporter.swift | 1 + 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/Examples/BombApp/BombApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Examples/BombApp/BombApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index a4a4f129..2caa7236 100644 --- a/Examples/BombApp/BombApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/Examples/BombApp/BombApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -105,8 +105,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/embrace-io/KSCrash.git", "state" : { - "revision" : "0468c294af9d271301bf8ad1942dc4aa3cf6ab08", - "version" : "2.0.6" + "revision" : "6ce425727d3895c14cd7ff839f788ccb2bcf4081", + "version" : "2.0.7" } }, { @@ -132,8 +132,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/open-telemetry/opentelemetry-swift", "state" : { - "revision" : "0dd37c4a14a6aeeb131eea40a13cb3832c7c6a97", - "version" : "1.10.1" + "revision" : "f2315d8646432c02338960e85b5fe20417ad6d8d", + "version" : "1.12.1" } }, { diff --git a/Examples/DemoObjectiveC/DemoObjectiveC.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Examples/DemoObjectiveC/DemoObjectiveC.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index 0b2bb2eb..5f6a7a6f 100644 --- a/Examples/DemoObjectiveC/DemoObjectiveC.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/Examples/DemoObjectiveC/DemoObjectiveC.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -24,8 +24,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/embrace-io/KSCrash.git", "state" : { - "revision" : "0468c294af9d271301bf8ad1942dc4aa3cf6ab08", - "version" : "2.0.6" + "revision" : "6ce425727d3895c14cd7ff839f788ccb2bcf4081", + "version" : "2.0.7" } }, { @@ -33,8 +33,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/open-telemetry/opentelemetry-swift", "state" : { - "revision" : "0dd37c4a14a6aeeb131eea40a13cb3832c7c6a97", - "version" : "1.10.1" + "revision" : "f2315d8646432c02338960e85b5fe20417ad6d8d", + "version" : "1.12.1" } }, { diff --git a/Package.resolved b/Package.resolved index 8a212676..876c3aef 100644 --- a/Package.resolved +++ b/Package.resolved @@ -23,8 +23,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/embrace-io/KSCrash.git", "state" : { - "revision" : "0468c294af9d271301bf8ad1942dc4aa3cf6ab08", - "version" : "2.0.6" + "revision" : "6ce425727d3895c14cd7ff839f788ccb2bcf4081", + "version" : "2.0.7" } }, { diff --git a/Package.swift b/Package.swift index 516ba0b1..636e8699 100644 --- a/Package.swift +++ b/Package.swift @@ -32,7 +32,7 @@ let package = Package( dependencies: [ .package( url: "https://github.com/embrace-io/KSCrash.git", - exact: "2.0.6" + exact: "2.0.7" ), .package( url: "https://github.com/open-telemetry/opentelemetry-swift", diff --git a/Sources/EmbraceCrash/EmbraceCrashReporter.swift b/Sources/EmbraceCrash/EmbraceCrashReporter.swift index 3889c219..7a7119e2 100644 --- a/Sources/EmbraceCrash/EmbraceCrashReporter.swift +++ b/Sources/EmbraceCrash/EmbraceCrashReporter.swift @@ -102,6 +102,7 @@ public final class EmbraceCrashReporter: NSObject, CrashReporter { let bundleName = context.appId ?? "default" ksCrash = KSCrash.sharedInstance(withBasePath: basePath, andBundleName: bundleName) + ksCrash?.reportsMemoryTerminations = false // this feature seems to have many issues, disabling it for now updateKSCrashInfo() ksCrash?.install()