Fixing SpanErrorCode.userAbandon raw string value (#149)

embrace-io · Dec 12, 2024 · 949d7ee · 949d7ee
1 parent 69ed424
commit 949d7ee
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Sources/EmbraceSemantics/Span/SpanErrorCode.swift b/Sources/EmbraceSemantics/Span/SpanErrorCode.swift
@@ -8,7 +8,7 @@ public enum SpanErrorCode: String {
     case failure
 
     /// Span ended because user reverted intent
-    case userAbandon
+    case userAbandon = "user_abandon"
 
     /// Span ended in some other way
     case unknown

diff --git a/Tests/EmbraceCoreTests/IntegrationTests/Embrace+OTelIntegrationTests.swift b/Tests/EmbraceCoreTests/IntegrationTests/Embrace+OTelIntegrationTests.swift
@@ -72,7 +72,7 @@ final class Embrace_OTelIntegrationTests: IntegrationTestCase {
             if let result = exporter.exportedSpans.values.first(where: { value in
                 value.name == "my-example-span"
             }) {
-                XCTAssertEqual(result.status, .error(description: "userAbandon"))
+                XCTAssertEqual(result.status, .error(description: "user_abandon"))
                 expectation.fulfill()
             }
         }

diff --git a/Tests/EmbraceOTelInternalTests/Trace/Tracer/Span/Processor/SingleSpanProcessorTests.swift b/Tests/EmbraceOTelInternalTests/Trace/Tracer/Span/Processor/SingleSpanProcessorTests.swift
@@ -206,7 +206,7 @@ final class SingleSpanProcessorTests: XCTestCase {
             let exportedSpan = try XCTUnwrap(self.exporter.exportedSpans[span.context.spanId])
             return exportedSpan.hasEnded &&
                    exportedSpan.status.isError &&
-                   exportedSpan.attributes[SpanSemantics.keyErrorCode] == .string("userAbandon")
+                   exportedSpan.attributes[SpanSemantics.keyErrorCode] == .string("user_abandon")
         }
     }
 
@@ -232,10 +232,10 @@ final class SingleSpanProcessorTests: XCTestCase {
 
             return span1.hasEnded &&
                    span1.status.isError &&
-                   span1.attributes[SpanSemantics.keyErrorCode] == .string("userAbandon") &&
+                   span1.attributes[SpanSemantics.keyErrorCode] == .string("user_abandon") &&
                    span2.hasEnded &&
                    span2.status.isError &&
-                   span2.attributes[SpanSemantics.keyErrorCode] == .string("userAbandon")
+                   span2.attributes[SpanSemantics.keyErrorCode] == .string("user_abandon")
         }
     }
 }