-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing WKNavigationDelegateProxy
#110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
delegate.webView?(webView, didFinish: navigation) | ||
delegate.webView?(webView, didReceive: URLAuthenticationChallenge(), completionHandler: block3) | ||
delegate.webViewWebContentProcessDidTerminate?(webView) | ||
delegate.webView?(webView, authenticationChallenge: URLAuthenticationChallenge(), shouldAllowDeprecatedTLS: block4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Line should be 120 characters or less; currently it has 123 characters (line_length
)
ArielDemarco
approved these changes
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 91.95% 91.84% -0.12%
==========================================
Files 408 410 +2
Lines 26457 26459 +2
==========================================
- Hits 24329 24300 -29
- Misses 2128 2159 +31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were implementing every method of the
WKNavigationDelegate
protocol which could cause issues when the original delegates didn't have an implementation.This PR removes the implementations for methods that were not being used, and the forwarding is now handled by overriding
responds(to:)
andforwardingTarget(for:)
.This is the same solution that we used in our
URLSessionDelegateProxy
.