App size measurement #111
Merged
App size measurement #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| window.makeKeyAndVisible() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
⚠️ Files should have a single trailing newline (trailing_newline)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 91.95% 91.99% +0.04%
==========================================
Files 408 410 +2
Lines 26457 26486 +29
==========================================
+ Hits 24329 24367 +38
+ Misses 2128 2119 -9 |
NachoEmbrace
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a new app in
Examplesthat helps measure the space the SDK occupies in an application.Details
The app is as simple as possible (
AppDelegate/SceneDelegate+ContentView) and consists of two targets, one that compiles only the previously components, and another that compiles depending on the local version of the Embrace SDK. Then, using Fastlane, two.ipafiles are created and the size of both is compared to obtain the compressed and uncompressed size. The difference between the two gives an estimate of the disk space occupied by the SDK.For more information on how it works, a specific
READMEhas been added to that example (Examples/AppSizeTester/README.md).