Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving network body capture rules #112

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

NachoEmbrace
Copy link
Contributor

So it's not needed to include the https:// prefix when creating the rules.
This PR makes it so the prefix gets ignored when doing the regex matching.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner October 31, 2024 16:01
Copy link

github-actions bot commented Oct 31, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Oct 31, 2024

Warnings
⚠️ No CHANGELOG entry added.
⚠️

Tests/EmbraceCoreTests/Capture/Network/DefaultURLSessionTaskHandlerTests.swift#L197 - Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)

Generated by 🚫 Danger Swift against a8f890d

@ArielDemarco ArielDemarco merged commit 83b0d33 into main Nov 1, 2024
9 checks passed
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (b2da5ac) to head (a8f890d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   91.95%   92.02%   +0.07%     
==========================================
  Files         408      410       +2     
  Lines       26457    26486      +29     
==========================================
+ Hits        24329    24375      +46     
+ Misses       2128     2111      -17     
Files with missing lines Coverage Δ
...ceCommonInternal/Protocols/DispatchableQueue.swift 100.00% <100.00%> (ø)
Sources/EmbraceConfigInternal/EmbraceConfig.swift 93.84% <100.00%> (ø)
...workPayloadCapture/URLSessionTaskCaptureRule.swift 89.36% <100.00%> (+0.72%) ⬆️
...ceCore/Capture/Network/URLSessionTaskHandler.swift 97.70% <100.00%> (ø)
...mbraceConfigInternalTests/EmbraceConfigTests.swift 100.00% <100.00%> (ø)
...re/Network/DefaultURLSessionTaskHandlerTests.swift 95.34% <100.00%> (ø)
...ayloadCapture/URLSessionTaskCaptureRuleTests.swift 100.00% <100.00%> (ø)
Tests/TestSupport/Mocks/MockQueue.swift 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@ArielDemarco ArielDemarco deleted the fix_network_body_capture_regex branch November 1, 2024 21:36
@ArielDemarco ArielDemarco restored the fix_network_body_capture_regex branch November 1, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants