Fixing log batches logic #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| self.cancelBatchDeadline() | ||
| self.delegate?.batchFinished(withLogs: batch.logs) | ||
| // TODO: Add cleanup step: |
There was a problem hiding this comment.
⚠️ TODOs should be resolved (Add cleanup step:) (todo)
Generated by 🚫 Danger Swift against c77bfbd |
ArielDemarco
approved these changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 91.95% 91.93% -0.03%
==========================================
Files 408 410 +2
Lines 26457 26465 +8
==========================================
+ Hits 24329 24330 +1
- Misses 2128 2135 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue could be easily triggered by sending many logs at the same time.
Since the function that was closing the batches was made async it caused a race condition when adding many logs 1 at a time.
This caused the log batcher to send batches of incorrect sizes.