[EMBR-5846] Fix URLSessionDelegate methods forwading based on responds and not only conformance
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Generated by 🚫 Danger Swift against e782e36 |
…legate but not the other ones (while responding to selectors)
NachoEmbrace
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses an issue where some methods from different
NSURLSessionDelegatesubprotocols (such asNSURLSessionDataDelegateorNSURLSessionTaskDelegate) may be implemented by the original delegate without explicitly declaring conformance to these subprotocols. Probably, this can work becauseFoundationlikely checks whether the object responds to a selector, rather than strictly verifying if it declares conformance to the protocol.To resolve this, our implementation now performs a similar behavior. If we detect that the original delegate does not explicitly conform to the expected subprotocol but responds to the relevant selectors, we directly forward the calls to the original delegate. This ensures compatibility with delegates that rely on runtime behavior for method resolution.
[WIP: Missing tests]