Attempt to fix WKNavigationDelegateProxy crash
#138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Generated by 🚫 Danger Swift against 8a9a11c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suspicion is that the original delegate is being deallocated in between the
respondsToandforwardingTargetcalls; which could result in the selector being called directly to the proxy causing an unrecognized selector crash.This PR changes the
originalDelegateproperty so it's retained by the proxy.I also updated the
UNUserNotificationCenterDelegateProxysince it will probably run into the same issues.Note that we were already doing this in the
URLSessionDelegateProxyclass.Note: Also attempting to fix some flaky tests.