Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing WebViewCaptureService proxy #139

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fixing WebViewCaptureService proxy #139

merged 1 commit into from
Dec 5, 2024

Conversation

NachoEmbrace
Copy link
Contributor

Using a single proxy was an oversight in the original implementation.
This PR changes the code so each webView has it's own proxy which should fix any weird issues some users are experiencing.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner December 4, 2024 20:06
Copy link

github-actions bot commented Dec 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Dec 4, 2024

Warnings
⚠️ No CHANGELOG entry added.

Generated by 🚫 Danger Swift against b7d17f9

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.55%. Comparing base (1dcd83c) to head (b7d17f9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...mbraceCore/Capture/WebView/WKWebView+Embrace.swift 84.61% 2 Missing ⚠️
...ceCore/Capture/WebView/WebViewCaptureService.swift 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   90.64%   90.55%   -0.10%     
==========================================
  Files         417      418       +1     
  Lines       27877    27876       -1     
==========================================
- Hits        25269    25243      -26     
- Misses       2608     2633      +25     
Files with missing lines Coverage Δ
...re/Capture/WebView/WKNavigationDelegateProxy.swift 93.47% <100.00%> (+0.62%) ⬆️
...Capture/UX/View/UIViewControllerHandlerTests.swift 98.93% <100.00%> (ø)
...s/Capture/WebView/WebViewCaptureServiceTests.swift 100.00% <100.00%> (ø)
...mbraceCore/Capture/WebView/WKWebView+Embrace.swift 84.61% <84.61%> (ø)
...ceCore/Capture/WebView/WebViewCaptureService.swift 75.16% <80.00%> (-5.23%) ⬇️

... and 1 file with indirect coverage changes

@NachoEmbrace NachoEmbrace merged commit 13fa8d7 into main Dec 5, 2024
10 checks passed
@NachoEmbrace NachoEmbrace deleted the webview_proxy_fix branch December 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants