Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sdk enabled logic to mimic android and backend #141

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

pablomatiasgomez
Copy link
Contributor

@pablomatiasgomez pablomatiasgomez commented Dec 5, 2024

Checklist

We want to have the exact same logic (than android and backend) to decide if the SDK is enabled or not.
The - 1 is because otherwise you can never get a value of 100.

Copy link

github-actions bot commented Dec 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Dec 5, 2024

Warnings
⚠️ No CHANGELOG entry added.
⚠️ No tests added / modified.

Generated by 🚫 Danger Swift against 8de4f98

@pablomatiasgomez pablomatiasgomez marked this pull request as ready for review December 6, 2024 16:53
@pablomatiasgomez pablomatiasgomez requested a review from a team as a code owner December 6, 2024 16:53
Copy link

1 similar comment
Copy link

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (1dcd83c) to head (8de4f98).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   90.64%   90.54%   -0.10%     
==========================================
  Files         417      418       +1     
  Lines       27877    27957      +80     
==========================================
+ Hits        25269    25314      +45     
- Misses       2608     2643      +35     
Files with missing lines Coverage Δ
...figInternal/EmbraceConfigurable/RemoteConfig.swift 93.54% <100.00%> (+0.44%) ⬆️

... and 5 files with indirect coverage changes

@ArielDemarco ArielDemarco merged commit a3a7fd0 into main Dec 10, 2024
10 checks passed
@ArielDemarco ArielDemarco deleted the pablomatiasgomez/fix-sampling-logic branch December 10, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants