Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing view spans logic #142

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fixing view spans logic #142

merged 2 commits into from
Dec 9, 2024

Conversation

NachoEmbrace
Copy link
Contributor

  • Visibility spans where not being ended correctly
  • The capture service now uses the foreground session end time to close the spans

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner December 6, 2024 17:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Warnings
⚠️ No CHANGELOG entry added.

Generated by 🚫 Danger Swift against 65c32b4

@ArielDemarco ArielDemarco changed the base branch from main to release/6.6.0 December 9, 2024 18:03
@NachoEmbrace NachoEmbrace merged commit 922b895 into release/6.6.0 Dec 9, 2024
6 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the ttfr_spans_fix branch December 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielDemarco ArielDemarco ArielDemarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEmbrace @ArielDemarco