-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding EmbraceSemantics
module
#27
Conversation
NachoEmbrace
commented
Jul 29, 2024
- Main purpose of this module is to not duplicate constants through out the code.
- This being a public module would also allow users of the SDK to generate OTel data using Embrace's semantics.
- Removed the usage of constants in tests (we do want hardcoded values there).
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Generated by 🚫 Danger Swift against 68a2f59 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 91.66% 91.69% +0.02%
==========================================
Files 386 384 -2
Lines 18169 18107 -62
==========================================
- Hits 16655 16603 -52
+ Misses 1514 1504 -10
|
Like the separation of these constants and how it's organized into a well name-spaced spot. It may be useful to differentiate OpenTelemetry semantic conventions from those that are Embrace specific (until we can get those pushed upstream).
Tried referencing the SemanticAttributes directly and realized it would probably be more of a headache to manage when conventions change but we're using an older version of the otel-swift dependency. May be easier to just have a comment on the |
…the `emb.type` attribute. Update SpanType, LogType to conform to new protocol Adds SpanEventType which also conforms to new protocol
@NachoEmbrace added a commit to this branch to make the Hoping this means we can have telemetry specific declarations and interfaces, but a common implementation to what the value of |
# Conflicts: # Sources/EmbraceCore/Capture/Network/URLSessionTaskHandler.swift