Resolve various typos throughout the SDK #63
Conversation
| /// - partitionIdentifier: The main paritition identifier to use | ||
| /// - partitionIdentifier: The main partitionfetched remote config | ||
| /// identifier to use |
There was a problem hiding this comment.
Could it be that there was some kind of error here when you were typing?
There was a problem hiding this comment.
Ah yes thanks for catching that, did an incorrect find and replace!
Sources/EmbraceSemantics/SpanEvent/SpanEventSemantics+Breadcrumb.swift
Outdated
Show resolved
Hide resolved
|
Hey @jstart! Thank you very much for the PR! You did a huge code review! And it's very helpful because anything that improves code readability is always beneficial 😁 |
|
@jstart seems there's a compiling issue on |
Ah thanks for catching that! I'll make sure all the test targets build and run. |
|
@ArielDemarco I think I got the tests green finally! Let me know if you think any other changes are required! |
|
This looks like it needs to be rebased off main. Should fix the conflicts and the test failures in LogExport |
Just pulled from main and handled the conflict! @ArielDemarco |
Co-authored-by: ArielDemarco <ariel.demarco@embrace.io>
jstart
force-pushed
the
truman/spellcheck
branch
from
2a61cfb to
d53c92c
Compare
|
I'll merge it as seem tests are working fine and |
Description
This PR resolves various typos found throughout the project in code comments and class/struct/function names. Not sure how helpful this is and I don't want to pollute the git history if that is a concern. Just wanted to clean up a few things as I get familiar with the codebase! :)
Checklist