Fixed bug that would create a request to /v2/logs endpoint w/o logs
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Generated by 🚫 Danger Swift against 905e622 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 400 400
Lines 26024 26029 +5
=======================================
+ Hits 23924 23930 +6
+ Misses 2100 2099 -1
|
atreat
approved these changes
Oct 1, 2024
NachoEmbrace
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Today when one or more logs are added, a batch is created. When that batch is closed at the end of the session, another batch without logs is generated. If the session ends without any logs being added to this new batch, it is being sent to the backend with no logs.
This PR fixes this issue and prevents backend calls when an empty batch is closed.