Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS 17.5 < simulators with cocoapods #78

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ArielDemarco
Copy link
Collaborator

@ArielDemarco ArielDemarco commented Oct 1, 2024

Overview

Fixed an issue that would cause a crash when running Embrace with devices with versions lower than iOS 17.5 after installing the SDK with Cocoapods.

@ArielDemarco ArielDemarco requested a review from a team as a code owner October 1, 2024 22:31
Copy link

github-actions bot commented Oct 1, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (fe3675e) to head (f4613d6).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.01%     
==========================================
  Files         400      400              
  Lines       26024    26024              
==========================================
- Hits        23924    23923       -1     
- Misses       2100     2101       +1     

see 3 files with indirect coverage changes

@atreat
Copy link
Contributor

atreat commented Oct 2, 2024

Do we need other platforms defined here too?

@ArielDemarco
Copy link
Collaborator Author

Do we need other platforms defined here too?

Yes, we'd have to define something for tvOS at least at some point; but we don't have enough tests in place to really test this

@NachoEmbrace NachoEmbrace merged commit 2726a4c into main Oct 2, 2024
10 checks passed
@NachoEmbrace NachoEmbrace deleted the fix-ios-17-and-less-issue branch October 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants