Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Embrace client's metadata to ObjC #85

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Expose Embrace client's metadata to ObjC #85

merged 2 commits into from
Oct 10, 2024

Conversation

Germantv
Copy link
Contributor

Description

MetadataHandler is defined as an ObjC class but not exposed to ObjC - Adding @objc to metadata prop in Embrace client to use in ObjC.

Checklist

  • PR Description to summarize changes
  • Add sufficient test coverage - Not sure if this is applicable as I just added one tiny change to prop
  • Read Contributing Guidelines
  • Agree to Embrace CLA

@Germantv Germantv requested a review from a team as a code owner October 10, 2024 03:05
@Germantv Germantv changed the title Add @objc to Embrace client metadata Expose Embrace client's metadata to ObjC Oct 10, 2024
ArielDemarco
ArielDemarco approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@ArielDemarco ArielDemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Germantv ! Thanks for your contribution! We totally missed this 😅
PR LGTM 👍

@ArielDemarco ArielDemarco mentioned this pull request Oct 10, 2024
Merged
@ArielDemarco
Copy link
Collaborator

The "Run Swift Tests" action failed, but not because any tests in the suite failed; it was due to an internal issue (which I address in this PR). Therefore, I see no issue with merging since the real check is that none of the tests are broken.
Again, thank you for your contribution @Germantv!

@ArielDemarco ArielDemarco merged commit 72a0884 into embrace-io:main Oct 10, 2024
5 of 6 checks passed
@Germantv
Copy link
Contributor Author

The "Run Swift Tests" action failed, but not because any tests in the suite failed; it was due to an internal issue (which I address in this PR). Therefore, I see no issue with merging since the real check is that none of the tests are broken. Again, thank you for your contribution @Germantv!

Super excited to be able to contribute! Love your guys' work!! 😄

@Germantv
Copy link
Contributor Author

Quick question @ArielDemarco - When will this go out into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielDemarco ArielDemarco ArielDemarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Germantv @ArielDemarco