From bfb85e132751dd82e408f0b1709e8940b2ae8a37 Mon Sep 17 00:00:00 2001 From: Ariel Demarco Date: Wed, 16 Oct 2024 15:12:49 -0300 Subject: [PATCH 1/3] Moved 'Codable' out of internal extension to prevent issues --- Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift b/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift index 021ec9b0..804f59b8 100644 --- a/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift +++ b/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift @@ -5,7 +5,7 @@ import Foundation @objc -public final class NetworkPayloadCaptureRule: NSObject { +public final class NetworkPayloadCaptureRule: NSObject, Decodable { public let id: String public let urlRegex: String public let statusCodes: [Int]? @@ -34,7 +34,7 @@ public final class NetworkPayloadCaptureRule: NSObject { } } -extension NetworkPayloadCaptureRule: Decodable { +extension NetworkPayloadCaptureRule { enum CodingKeys: String, CodingKey { case id case urlRegex = "url" From 87a468eedd2934102864ca3fe54d7277f196cf72 Mon Sep 17 00:00:00 2001 From: Ariel Demarco Date: Wed, 16 Oct 2024 15:15:50 -0300 Subject: [PATCH 2/3] Added deployment_target to EmbraceConfiguration --- Project.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/Project.swift b/Project.swift index db484ea8..dccd28a6 100644 --- a/Project.swift +++ b/Project.swift @@ -116,6 +116,7 @@ let project = Project( destinations: .iOS, product: .framework, bundleId: "com.embraceio.EmbraceConfiguration", + deploymentTargets: .iOS("13.0"), sources: ["Sources/EmbraceConfiguration/**"], dependencies: [], settings: .settings(base: [ From 8edf8e23936715714aa83d459347f847f484a03f Mon Sep 17 00:00:00 2001 From: Ariel Demarco Date: Wed, 16 Oct 2024 17:21:35 -0300 Subject: [PATCH 3/3] Fix linting --- Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift b/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift index 804f59b8..f3fbf4d9 100644 --- a/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift +++ b/Sources/EmbraceConfiguration/NetworkPayloadCaptureRule.swift @@ -5,7 +5,7 @@ import Foundation @objc -public final class NetworkPayloadCaptureRule: NSObject, Decodable { +public final class NetworkPayloadCaptureRule: NSObject, Decodable { public let id: String public let urlRegex: String public let statusCodes: [Int]?