Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule/feeds: make json feed schema compatible #1612

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Kunsi
Copy link
Contributor

@Kunsi Kunsi commented May 24, 2024

No description provided.

@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch 2 times, most recently from d94e2f3 to d70ab38 Compare May 24, 2024 10:51
@Kunsi Kunsi marked this pull request as ready for review May 24, 2024 11:03
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch from 174dd59 to 550b857 Compare August 14, 2024 15:30
@Kunsi Kunsi marked this pull request as draft August 14, 2024 16:54
@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch 3 times, most recently from 9832e92 to ee12ce8 Compare August 14, 2024 16:59
@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch from ee12ce8 to c2e1603 Compare August 14, 2024 17:01
@Kunsi
Copy link
Contributor Author

Kunsi commented Aug 14, 2024

I re-set this to draft state because the machine i used to test this on is no longer available, and i don't have any other machines running docker atm

@Kunsi Kunsi force-pushed the kunsi-schedule-json-schema-compatible branch from e8ee349 to d41b13b Compare August 14, 2024 18:23
apps/schedule/schedule_json.py Outdated Show resolved Hide resolved
@Kunsi Kunsi marked this pull request as ready for review August 31, 2024 12:25
@Kunsi
Copy link
Contributor Author

Kunsi commented Aug 31, 2024

Screenshot 2024-08-31 at 14-25-02
Tested, works.

Copy link
Member

@wlcx wlcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good inclusion I think, thanks!

I wonder if we should be generating the data for this in one place though, given this is all the same stuff that's in the frab xml exporter. Removes the possiblity of accidentally having the two not agree!

apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/feeds.py Outdated Show resolved Hide resolved
apps/schedule/schedule_json.py Outdated Show resolved Hide resolved
apps/schedule/schedule_json.py Outdated Show resolved Hide resolved
}
for name in (proposal.published_names or proposal.user.name).split(",")
],
"recording_license": "CC BY-SA 3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're at 4.0 now - see #1643

Would probably be good to set this in a single place. I expect a constant or config item would be fine!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would propose i'll create a separate PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants