Add /arcade and program #1662
Closed
Add /arcade and program #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def render_markdown(source, **view_variables): | ||
| template_root = Path(path.join(app.root_path, app.template_folder)).resolve() | ||
| source_file = template_root.joinpath(f"{source}.md").resolve() |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| template_root = Path(path.join(app.root_path, app.template_folder)).resolve() | ||
| source_file = template_root.joinpath(f"{source}.md").resolve() | ||
|
|
||
| if not source_file.is_relative_to(template_root) or not source_file.exists(): |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if not source_file.is_relative_to(template_root) or not source_file.exists(): | ||
| return abort(404) | ||
|
|
||
| with open(source_file, "r") as f: |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
|
Rebased and merged as d368da7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds /arcade, and subpages for the content.
I copied the structure and generation of /about because having
.mdfiles for the entries appealed to me, but it might have been a slightly jank way of achieving this, open to suggestions. The<details>tag to make the nav usable might need some styling work.