Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content note and video privacy information to feeds #1719

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edk0
Copy link
Contributor

@edk0 edk0 commented Jun 1, 2024

It's been annoying me that these aren't there

@edk0 edk0 force-pushed the video-privacy-and-content-note-in-feeds branch from f20b3ad to 69083a6 Compare June 1, 2024 15:19
@@ -35,10 +42,12 @@ def _format_event_description(event):
if event["map_link"]:
venue_str = f'{venue_str} ({event["map_link"]})'
footer_block.append(f'Venue: {venue_str}')
if event["type"] in ("talk", "lightning talk", "performance") and event["video_privacy"] != "public":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the type actually lightning talk at this point, or is it lightningtalk.

apps/schedule/feeds.py Outdated Show resolved Hide resolved
@edk0
Copy link
Contributor Author

edk0 commented Jun 2, 2024

Lightning talks are untestable here and I only really added them because they made conceptual sense; they don't appear in the schedule afaik. Also I can't test performances because I can't make them recordable locally, did we do that via the db?

Anyway I fixed the type thing in theory, and it still looks ok for talks.

@edk0 edk0 force-pushed the video-privacy-and-content-note-in-feeds branch 2 times, most recently from f653130 to 7f328fe Compare June 2, 2024 11:53
@edk0 edk0 requested a review from marksteward June 2, 2024 13:01
@edk0 edk0 force-pushed the video-privacy-and-content-note-in-feeds branch from 7f328fe to 6499dbb Compare June 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants