Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pump dependency, missing after #1735 #1751

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add pump dependency, missing after #1735 #1751

merged 1 commit into from
Jul 9, 2024

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jun 27, 2024

Oops.

@lukegb lukegb enabled auto-merge June 27, 2024 12:53
jayaddison
jayaddison approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

(this prompted me to do a quick manual inspection to check that all of the dependencies imported by the gulpfile.js are listed in package.json; with this in place, indeed they all are)

@lukegb lukegb merged commit b41953e into main Jul 9, 2024
3 checks passed
@lukegb lukegb deleted the add-pump branch July 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayaddison jayaddison jayaddison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukegb @jayaddison