Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C3VOC tests adjustments #1776

Merged
merged 11 commits into from
Sep 2, 2024
Merged

C3VOC tests adjustments #1776

merged 11 commits into from
Sep 2, 2024

Conversation

jayaddison
Copy link
Contributor

Miscellaneous changes - note that behaviour adjustments (and token value changes) are included, so this isn't strictly a refactoring.

@jayaddison
Attempted refactor: use pytest fixture setup/teardown
7bcb34c 
Note: not working currently when the tests run in random order
@jayaddison
Tests: c3voc: use default function scope for proposal fixture
3b6d12b
@jayaddison
Tests: c3voc: fixup: attribute name correction
015c140
@jayaddison
Tests: c3voc: refactor: relocate API token to test.cfg
ce25699
@jayaddison
Tests: c3voc: minify diff: rollback to commit instead of flush
fdee19b 
This was introduced in 7bcb34c when I was wondering why random-order tests were failing; I'd misattributed `sqlalchemy` identity map caching as a potential cause.  The true reason was the `module` scope of the `proposal` fixture, resolved by 3b6d12b.
@jayaddison
Tests: c3voc: nitpick: use initializer keyword-args.
162b1fe
@jayaddison
Tests: c3voc: provide valid proposal.id during denied requests.
0788cd4 
Rationale: reduce the likelihood that the test failure is due to other validation/logic conditions.
@jayaddison
Tests: c3voc: nitpick: prefer is to == for boolean comparisons.
b996797
@jayaddison
Tests: c3voc: extract common HTTP auth headers fixture.
435e2f1
@jayaddison jayaddison mentioned this pull request Sep 1, 2024
Merged
fkusei
fkusei suggested changes Sep 2, 2024
View reviewed changes
Copy link

@fkusei fkusei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean_proposal() set video_recording_lost to True by default.

tests/test_api_c3voc.py Show resolved Hide resolved
tests/test_api_c3voc.py Show resolved Hide resolved
@jayaddison
Copy link
Contributor Author

Thanks for the code review @Kunsi! Merging this in a few moments..

@jayaddison
Copy link
Contributor Author

(ah; no I'm not yet, because we need another review approver from the org)

@jayaddison jayaddison merged commit ea74e76 into main Sep 2, 2024
3 checks passed
@jayaddison jayaddison deleted the pr-1770-1774-followup/test-refactoring branch September 2, 2024 19:54
@jayaddison
Copy link
Contributor Author

Thanks @russss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkusei fkusei fkusei requested changes

@russss russss russss approved these changes

@Kunsi Kunsi Kunsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayaddison @russss @Kunsi @fkusei