Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add headers uac features #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SilvaMendes
Copy link

Add to the uac response the facilities that the client offers as an endpoint.
pullrequest

@emiago
Copy link
Owner

emiago commented Oct 18, 2024

@SilvaMendes Thanks for contribution. Please open issue first. I hate to reject stuff.
I see no point here this adding. Those headers are optional. What problem you have, why you think changing this makes more sense?

@SilvaMendes
Copy link
Author

To maintain the compatibility of the resources that the endpoint offers, taking into account that in my case I am not using opensips with the b2c_logic module, so it does not break the initial tm request.

@emiago
Copy link
Owner

emiago commented Oct 18, 2024

I understand what this headers mean, but having that implicit behavior is questionable. Normally you as server or as client should build this up. I think this things need to go either on client or server.
sipgo needs to be minimalistic, this is API to provide minimal (MUST / correct) response. All optional must be treated as optional. I see more having this on diago project.
FYI: this things I have build manually either as part of response or as custom prebuilt request.

I think this could be worked more on client or server, but still leave caller to wrapup this behavior.
Changing this to issue. To give more context, please take time to explain on issue what happens if this headers are not present in your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants