Update CI deployment #139
Update CI deployment #139
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…for linux Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
It's failing with the latest changes Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
ping @emilk |
| - name: Install build dependencies - Rustup | ||
| run: | | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain stable --profile default --target ${{ matrix.TARGET }} -y | ||
| echo "$HOME/.cargo/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Why this instead of using actions-rs/toolchain?
There was a problem hiding this comment.
This action is deprecated/archived and I think that the usage is not recommended.
There was a problem hiding this comment.
@patrickelectric did you consider using dtolnay/rust-toolchain? Its what I've done in my own little hotfix.
There was a problem hiding this comment.
Thanks @9SMTM6! Ill take a look.
There was a problem hiding this comment.
@patrickelectric I'm currently testing a pretty big rewrite of this toolchain on my app. So perhaps wait.
One of the core issues was the heavy usage of cross. I was able to remove all usages of cross other than for arm64 linux. The other was that this PR still leaves A LOT of uses of actions-rs in the pipeline. A bunch of toolchain commands, which I had removed earier in my pipeline, but also a bunch of action-rs/cargo etc actions, I have overlooked these in my own toolchain too.
At the moment, it appears that musl targets are not working: rust-windowing/winit#1818
To use gnu, it's necessary to use glib 2.27, for that, cross need to be installed manually from development branch: cross-rs/cross#1510