-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm hooks for admission controller deplolyment #30
Add helm hooks for admission controller deplolyment #30
Conversation
Add helm hooks for admission controller deplolyment
@mlladb Thanks for the PR. We want to reject DNSClass object if the validation fails. If we do this, we would skip that process. I think we should add a DNSClass template inside the existing template and applying it with a hook so that it gets applied last. Would you be interested in contributing a commit for this feature? |
Admissioncontroller helmhook weight
enable gorelease
hardcode repository
hardcode test image
93d7b1a
to
b57c2c2
Compare
I've add the kubedns-shepherd:
certmanager:
enabled: false
dnsclass:
allowedNamespaces:
- default
- kubedns-shepherd
disabledNamespaces:
- kube-system
allowedDNSPolicies:
- None
- ClusterFirst
- ClusterFirstWithHostNet
dnsPolicy: None
dnsConfig:
nameservers:
- 172.20.0.10
searches:
- "{{ .podNamespace }}.svc.cluster.local"
- "svc.cluster.local"
- "cluster.local"
options:
- name: ndots
value: "3"
- name: edns0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution and validation—it’s highly appreciated. I’ve made a few suggestions. Please review them.
I also realized that your changes would work for Argo but when Helm applies the changes it will fail because it requires to wait the pods to be ready. I will include your changes and improve it. Thanks for your support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've tested the following fix for the further issue described in Issue 25 at it works as expected. I don't think there are any likely issues to appear due to this change.