Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in functions_advanced notebook #170

Open
fabioacl opened this issue Dec 11, 2023 · 4 comments
Open

Errors found in functions_advanced notebook #170

fabioacl opened this issue Dec 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@fabioacl
Copy link
Contributor

fabioacl commented Dec 11, 2023

No description provided.

@fabioacl fabioacl reopened this Dec 11, 2023
@edoardob90 edoardob90 changed the title Errors found in functions_advanced.ipynb notebook Errors found in functions_advanced.ipynb notebook Dec 11, 2023
@fabioacl
Copy link
Contributor Author

In the Decorators, there is a typo in the print inside the fcounter function: has beel instead of has been.

@edoardob90 edoardob90 pinned this issue Dec 11, 2023
@edoardob90 edoardob90 changed the title Errors found in functions_advanced.ipynb notebook Errors found in functions_advanced notebook Dec 12, 2023
@GCatarina
Copy link

Suggestion:

In Fibonnaci sequence using reduce, maybe it would be helpful to also have a reminder that reduce can have a 3rd entry which is the starting point for the sum

@anates
Copy link

anates commented Dec 12, 2023

In the last example (once), the following line is missing:

import typing as t

@anates
Copy link

anates commented Dec 12, 2023

In the example code in the same example (once), given as

import time

@once(15)
def hello(name):
    return f"Hello, {name}!"

for i in range(30):
    print(i)
    try:
        time.sleep(3)
        print(hello(f"attempt #{i}"))
    except TooSoonError as err:
        print(f"Too soon: {err}")

the example error is defined as TooSoonError, which is not defined else. As discussed on Slack, this is a leftover from testing, and could be marked as such.
Thanks!

@yakutovicha yakutovicha unpinned this issue Dec 13, 2023
@edoardob90 edoardob90 added the bug Something isn't working label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants