Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bypass superpin environment settings #8

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

marcoraddatz
Copy link
Member

@marcoraddatz marcoraddatz commented Sep 17, 2024

BREAKING CHANGE

This PR introduces the ability to bypass certain environment restrictions.

Use case

There are situations where you may need to provide a third party with access to your system, such as when Apple’s app store review team requires a username and password to log in. Previously, logging in with a superpin in a production environment was not possible because the user wouldn’t receive an email notification.

This PR enhances the security of the package in two key ways:

  1. You can now manually specify which environments allow the use of a superpin (enabled on testing and local by default). Production will continue to be disabled.
  2. Specific identifiers can bypass environment checks. For example, a user with a particular email address can log in to production, even if production is disabled in the environment settings.

Migration

  • Move your superpin configuration from config('totp-login.superpin') to config('totp-login.superpin.pin').
  • Optionally, add the other totp-login.superpin.* config entries. The staging system is not allowed to use the superpin by default.

@marcoraddatz marcoraddatz self-assigned this Sep 17, 2024
@marcoraddatz marcoraddatz added the enhancement New feature or request label Sep 17, 2024
@marcoraddatz marcoraddatz marked this pull request as ready for review September 17, 2024 14:57
@marcoraddatz marcoraddatz merged commit d0bb5c7 into main Sep 17, 2024
27 checks passed
@marcoraddatz marcoraddatz deleted the feature/bypass-superpin-environment branch September 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant