Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split pyjs up in pyjs and pyjs_core #57

Merged
merged 12 commits into from
Mar 12, 2024

Conversation

DerThorsten
Copy link
Collaborator

pyjs implements a lot of its functionality in pure Python on top of the C++ Code. But since pyjs is an embedded Python module (ie one which lives directly in the code instead of a side package) the pure Python code is added via py::eval("some code") instead of files.
This is ugly and hard to maintain, therefore pyjs used some hacks to create the py::eval("some code") statements from actual files with Python code. But this hack had some scoping issues and is ugly and not nice to maintain and explain.
Therefore this PR moves the pure Python code to a dedicated top-level package called pyjs. The old pyjs embedded package is renamed to pyjs_core.
From a user / API perspective, nothing changes since we can do from pyjs_core import * within pyjs

@DerThorsten
Copy link
Collaborator Author

DerThorsten commented Mar 11, 2024

needs a new release of pyjs-code-runner with emscripten-forge/pyjs-code-runner#14 ( ATM we install pyjs-code-runner from main by hand in the CI in this PR)

@DerThorsten DerThorsten merged commit ed58488 into emscripten-forge:main Mar 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant