split pyjs up in pyjs and pyjs_core #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyjs
implements a lot of its functionality in pure Python on top of the C++ Code. But sincepyjs
is an embedded Python module (ie one which lives directly in the code instead of a side package) the pure Python code is added viapy::eval("some code")
instead of files.This is ugly and hard to maintain, therefore pyjs used some hacks to create the
py::eval("some code")
statements from actual files with Python code. But this hack had some scoping issues and is ugly and not nice to maintain and explain.Therefore this PR moves the pure Python code to a dedicated top-level package called
pyjs
. The oldpyjs
embedded package is renamed topyjs_core
.From a user / API perspective, nothing changes since we can do
from pyjs_core import *
withinpyjs