Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test string from cornflakes to more purposeful names #252

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

amazingrando
Copy link
Contributor

@amazingrando amazingrando commented Mar 1, 2024

Summary

This PR replaces the string /home/uname/Projects/cornflake/web/themes/custom/cornflake/ in tests with /home/username/Projects/drupal-project/web/themes/custom/themename/.

This PR relates to a comment that came up in #173.

The reason for this change is 1) no one knows what "cornflake" is, and 2) making the directory names semantic.

How to review this pull request

  • Run npm run test and confirm that all tests pass.

Copy link
Contributor

@mikeethedude mikeethedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye cornflake, you were fun but maybe too much like a real theme name. 🙏

This looks great Randy. Tests pass. Nothing in here that would cause issues elsewhere.

@mikeethedude mikeethedude added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Mar 1, 2024
Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP Cornflake

@amazingrando amazingrando merged commit 1e5bb29 into develop Mar 1, 2024
3 checks passed
@amazingrando amazingrando deleted the replace-test-string branch March 1, 2024 21:07
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants