-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test string from cornflakes to more purposeful names #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye cornflake, you were fun but maybe too much like a real theme name. 🙏
This looks great Randy. Tests pass. Nothing in here that would cause issues elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIP Cornflake
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This PR replaces the string
/home/uname/Projects/cornflake/web/themes/custom/cornflake/
in tests with/home/username/Projects/drupal-project/web/themes/custom/themename/
.This PR relates to a comment that came up in #173.
The reason for this change is 1) no one knows what "cornflake" is, and 2) making the directory names semantic.
How to review this pull request
npm run test
and confirm that all tests pass.