Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Testing Comments #1

Open
codechefmarc opened this issue Mar 16, 2024 · 0 comments
Open

Initial Testing Comments #1

codechefmarc opened this issue Mar 16, 2024 · 0 comments
Labels

Comments

@codechefmarc
Copy link
Collaborator

These are initial testing comments based on the new emulsify_tools and the new emulsify_drupal base theme.

Here's what I did to install things:

  1. Clean Drupal site with no theming. No Sous.
  2. Inside the web/themes/contrib directory, cloned down the emulsify-drupal base theme and switched to the branch release-base-theme
  3. Inside the web/modules/contrib, cloned down the new emulsify_tools module.
  4. Enabled the emulsify_tools module
  5. From root, ran drush emulsify atrus and got a new theme under web/themes/custom/atrus
  6. Attempted to install the UI kit by running the following from within the theme directory: emulsify system install uikit, emulsify system-install emulsify-ui-kit. Neither of these worked. I received the error: ERROR Unable to download specified system. You must either specify a valid name of an out-of-the-box system using the --name flag, or specify a valid repository and branch/tag/commit using the --repository and --checkout flags. That is a different issue, I'm sure.
  7. So, instead, I installed UI kit this way: emulsify system install --repository https://github.com/emulsify-ds/emulsify-ui-kit.git --checkout main It installed without errors, but there were no components under the components directory so things did not work.
  8. Lastly, I created a totally new theme from step 5 and called it yeesha
  9. Then, installed compound via emulsify system install compound and that worked fine.
  10. Then ran npm install and npm run build from within the theme directory.
  11. Marked this new theme as default. Cleared cache.
  12. The CSS was not loading. Checking yeesha.info.yml I noticed that the libraries was attempting to load - emulsify/global which is not correct. This should be changed to yeesha/base. Once I changed that and cleared cache, the styles loaded fine.
  13. Finally, I have some small edits to the Drush command (mainly some linting fixes as well as adding a dependency injection.) Which I will put into a PR.

Overall things look good with the exception of the libraries and UI kit issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

1 participant