Typing for add_middleware
breaks with suggested CORS config.
#2423
-
Hi! We are using the application.add_middleware(
CORSMiddleware,
allow_origins=["*"],
allow_credentials=False,
allow_methods=["*"],
allow_headers=["*"],
) After updating starlette, we got this error from mypy
Its somehow related to this PR: #2381 Any Idea on how to fix this ? |
Beta Was this translation helpful? Give feedback.
Answered by
ArzelaAscoIi
Jan 17, 2024
Replies: 1 comment 2 replies
-
What's the mypy version? I can't reproduce that. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
argh. you are right. 1.8.0 fixed it. Sorry and thanks for your help!