Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable branch = true for coverage.run #2452

Open
Kludex opened this issue Jan 31, 2024 · 4 comments
Open

Enable branch = true for coverage.run #2452

Kludex opened this issue Jan 31, 2024 · 4 comments
Labels
good first issue Good for beginners

Comments

@Kludex
Copy link
Member

Kludex commented Jan 31, 2024 •
edited by polar-sh bot
Loading

The goal here is to enable branch = true on tool.coverage.run. We want to be able to cover all logic paths.

Important

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Kludex Kludex added the good first issue Good for beginners label Jan 31, 2024
This was referenced Feb 10, 2024
Closed
Merged
ShreySinha02 added a commit to ShreySinha02/starlette that referenced this issue Feb 15, 2024
@ShreySinha02
set branch=True encode#2452
83cb6c9
@ShreySinha02
Copy link

ShreySinha02 commented Feb 15, 2024 •
edited
Loading

opened #2513

@ShreySinha02
Copy link

can not pass on --fail-under=100 but on 99 it can pass the the coverage

@Kludex
Copy link
Member Author

Kludex commented Feb 15, 2024

Well, the goal is exactly to add tests...

@TechNiick
Copy link
Contributor

There was already a PR open for this issue here.
I have started to work on test coverage. The first PR was opened here.
After merging this first one I will continue with the rest of them.

@Orenoid Orenoid mentioned this issue Aug 1, 2024
Merged
3 tasks
This was referenced Aug 31, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kludex @TechNiick @ShreySinha02