Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to test_datastructure #2505

Merged
merged 5 commits into from
Mar 24, 2024
Merged

Add tests to test_datastructure #2505

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dcdbc4
Add tests to test_datastructure
Feb 11, 2024
e67cea0
Merge branch 'master' into unit-tests/test-datastructures
TechNiick Feb 26, 2024
d6d7d3c
Merge branch 'master' into unit-tests/test-datastructures
TechNiick Mar 3, 2024
ed4c4c4
Update tests
Kludex Mar 24, 2024
2ae872e
Merge branch 'master' into unit-tests/test-datastructures
Kludex Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/test_datastructures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ def test_url() -> None:
url = URL("http://u:p@host:80")
assert url.replace(port=88) == URL("http://u:p@host:88")

url = URL("http://host:80")
assert url.replace(username="u") == URL("http://u@host:80")


def test_url_query_params() -> None:
u = URL("https://example.org/path/?page=3")
Expand All @@ -70,6 +73,10 @@ def test_url_query_params() -> None:
assert str(u) == "https://example.org/path/?order=name"
u = u.remove_query_params("order")
assert str(u) == "https://example.org/path/"
u = u.include_query_params(page=4, search="testing")
assert str(u) == "https://example.org/path/?page=4&search=testing"
u = u.remove_query_params(["page", "search"])
assert str(u) == "https://example.org/path/"
Comment on lines +76 to +79
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you testing here?

Better to post the lines you are testing, otherwise, this will take some time for me.



def test_hidden_password() -> None:
Expand Down Expand Up @@ -138,6 +145,21 @@ def test_url_from_scope() -> None:
assert u == "https://example.org/path/to/somewhere?abc=123"
assert repr(u) == "URL('https://example.org/path/to/somewhere?abc=123')"

u = URL(
scope={
"scheme": "http",
"path": "/some/path",
"query_string": b"query=string",
"headers": [
(b"content-type", b"text/html"),
(b"host", b"example.com:8000"),
(b"accept", b"text/html"),
],
}
)
assert u == "http://example.com:8000/some/path?query=string"
assert repr(u) == "URL('http://example.com:8000/some/path?query=string')"


def test_headers() -> None:
h = Headers(raw=[(b"a", b"123"), (b"a", b"456"), (b"b", b"789")])
Expand Down