Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QrSigner/QrSender page? #676

Closed
clangenb opened this issue Jul 15, 2022 · 1 comment · Fixed by #726
Closed

Remove QrSigner/QrSender page? #676

clangenb opened this issue Jul 15, 2022 · 1 comment · Fixed by #726
Labels
F1-shallow-encointer-domain Needs a bit of encointer domain knowledge JS Requires changes in JS code

Comments

@clangenb
Copy link
Member

clangenb commented Jul 15, 2022 •
edited
Loading

We have inherited signing transactions that are scanned via a QR-code to send transactions with (I believe, I did not spend too much time into understanding) offline signature and multiparty-signature support. I don't see this happening currently, shall we remove the code?
@clangenb clangenb added the question Further information is requested label Jul 15, 2022
@clangenb clangenb mentioned this issue Jul 15, 2022
Merged
@clangenb clangenb changed the title Remove QrSigner/QrSender page Remove QrSigner/QrSender page? Jul 15, 2022
@brenzi
Copy link
Member

brenzi commented Jul 17, 2022

We actually have our own, different ideas for sth similar:
#441
I think we can purge this legacy

@clangenb clangenb added JS Requires changes in JS code F1-shallow-encointer-domain Needs a bit of encointer domain knowledge and removed question Further information is requested labels Aug 7, 2022
@clangenb clangenb mentioned this issue Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F1-shallow-encointer-domain Needs a bit of encointer domain knowledge JS Requires changes in JS code
Projects
None yet
Milestone
No milestone
2 participants
@brenzi @clangenb