Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tags for cycleReleaseDate and latestReleaseDate #943

Closed
usta opened this issue Mar 19, 2022 · 15 comments · Fixed by #1264
Closed

new tags for cycleReleaseDate and latestReleaseDate #943

usta opened this issue Mar 19, 2022 · 15 comments · Fixed by #1264
Labels
enhancement New feature or request request Request for a new tool or changes

Comments

@usta
Copy link
Member

usta commented Mar 19, 2022

Right now we are using release tag to mention related cycle's first version date
and i am suggesting to rename this one to cycleReleaseDate
and add a new tag for the release date of latest tag for related cycle's latest version latestReleaseDate

These two tags will make it less confusing for the contributors and also let our api will be much cleaner

And yes i know it will bring a lttle more burden to us/contributors to add each new/latest versions release dates
but i believe we can handle that one

As a summary :
release --> cycleReleaseDate : To mention current series' first version date
add latestReleaseDate : To mention the latest version date

@usta usta added enhancement New feature or request request Request for a new tool or changes labels Mar 19, 2022
@usta
Copy link
Member Author

usta commented Mar 19, 2022

@captn3m0 @BiNZGi

@captn3m0
Copy link
Member

I like this proposal, let me give it a shot to see how much extra effort it will be. Might need a bit of help with latest release dates that makes me think this is something we should consider after we have automation in place to update latest releases.

@BiNZGi
Copy link
Member

BiNZGi commented Mar 21, 2022

I find this extension also useful 👍

@captn3m0
Copy link
Member

captn3m0 commented Mar 25, 2022

With #974, the latestReleaseDate is available for all products as part of the repo. As an example, see https://github.com/endoflife-date/release-data/blob/main/releases/git/alpinelinux.json#L399-L409. Unfortunately, dates are hard, and I'm sticking to UTC, which means some dates might be inaccurate (+-1 day). This automation also lets us find the "first release" in a cycle, so we get a lot more accurate data (I was having to guess release lengths)

I also felt the need for tracking both separately while working on #285 for the visual timeline. Would have been nice to put a dot for the latest release in each cycle.

@usta
Copy link
Member Author

usta commented Mar 25, 2022 via email

@captn3m0
Copy link
Member

Will bump in the next automation PR 👍🏽.

@captn3m0
Copy link
Member

Both latestReleaseDate and release are now automatically updating for lots of pages now. Can go ahead with the rename (release -> releaseDate / cycleReleaseDate) now.

@captn3m0
Copy link
Member

Had one question regarding contributions for latestReleaseDate: since we aren't using this date anywhere yet, we aren't enforcing this on contributions yet.

However, while all automated pages will include this information, this won't be present on the other pages - this makes the field optional. Should we request contributors to update this field for the non-automated pages?

@usta
Copy link
Member Author

usta commented May 29, 2022

I think that will be a perfect solution, i believe it wont be so hard to add 1 more line modification for contributors ( including me )

@usta
Copy link
Member Author

usta commented May 29, 2022

but we have to be sure we need to completely remove release or releaseDate and rename it as cycleReleaseDate this will solve all misunderstandings and it ill affect correct usage of latestReleaseDate tag

@usta
Copy link
Member Author

usta commented May 30, 2022

@captn3m0 Thank you 👍 💯 🥇 🎉 ❤️
This made everything much cleaner and more understandable
maybe just maybe we might also change support -> supportUntil this is completely optional :)
what do you think @BiNZGi ?

@captn3m0
Copy link
Member

supportDate maybe? Going with the releaseDate convention?

@usta
Copy link
Member Author

usta commented May 30, 2022

the problem starts not because of missing Date part but the problem new contributors think that its support starts in that date :)

@usta
Copy link
Member Author

usta commented May 30, 2022

but as i said before, this is completely trivial so even now we got rocksolid system :)

@BiNZGi
Copy link
Member

BiNZGi commented May 30, 2022

I would stay with support because possible values are also true|false and that don't fit good with until...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request Request for a new tool or changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants