Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update php version info #299

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Update php version info #299

merged 1 commit into from
Jul 18, 2021

Conversation

usta
Copy link
Member

@usta usta commented Jul 18, 2021

No description provided.

@usta
Copy link
Member Author

usta commented Jul 18, 2021

image

@captn3m0 captn3m0 added the release-updates Pull Requests that update release information label Jul 18, 2021
@usta
Copy link
Member Author

usta commented Jul 18, 2021

@captn3m0 does your system accept svg for releaseImage tag ? If yes we can add https://www.php.net/images/bg-texture-00.svg

@usta
Copy link
Member Author

usta commented Jul 18, 2021

i might be wrong about that svg link , you can check this one :
https://www.php.net/supported-versions.php

@captn3m0
Copy link
Member

captn3m0 commented Jul 18, 2021 •
edited
Loading

No, that SVG URL is incorrect. I've checked this earlier, PHP embeds the SVG inside the HTML source code: https://github.com/php/web-php/blob/c0afd74bf75f68d6939050fa0989e56aedaecacd/images/supported-versions.php

So we can't embed it. However, this should get sorted once #285 is merged.

@captn3m0 captn3m0 merged commit 54de894 into endoflife-date:master Jul 18, 2021
@captn3m0
Copy link
Member

Thanks for the updates 💯

@usta usta deleted the patch-1 branch July 18, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 approved these changes

Assignees
No one assigned
Labels
release-updates Pull Requests that update release information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usta @captn3m0