[new product] Mondoo cnspec #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open source plugin-based policy as code engine Signed-off-by: Tim Smith <tsmith84@gmail.com>
misterpantz
reviewed
Dec 26, 2024
misterpantz
reviewed
Dec 26, 2024
misterpantz
reviewed
Dec 26, 2024
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
misterpantz
approved these changes
Dec 26, 2024
marcwrobel
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Thanks for this contribution @tas50.
Overall LGTM, but I have a question and a few suggestions that I would like to be discussed before merging.
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
|
Thank for the review/suggestions @marcwrobel. I've pulled in everything |
marcwrobel
approved these changes
Jan 4, 2025
|
Thanks @marcwrobel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open source plugin-based policy as code engine