Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging environment #664

Merged
merged 236 commits into from
Nov 8, 2023
Merged

Update staging environment #664

merged 236 commits into from
Nov 8, 2023

Conversation

jrhender
Copy link
Collaborator

@jrhender jrhender commented Sep 19, 2023

This PR will update the staging environment to the v2.13 release of ssi-hub https://github.com/energywebfoundation/ssi-hub/releases/tag/v2.13.0

This PR was prepared by:

  1. branching from master to this master-merge branch
  2. merging develop (at dca0e34) into master-merge
    These steps were taken to fix the merge conflict in prod/Dockerfile

TODO:

michalziobro and others added 30 commits September 22, 2022 10:13
* fix: add logging for role credential resolver

* fix: remove IPFS import

* fix: add log for undefined DID store in DID service

* fix: remove unnecessary logs

* fix: throw error instead of log if DIDService is undefined
…urces_are_not_cleared

bug/did service resources are not cleared on destroy
* fix: make revoker service injectable

* fix: add injectable Role Revoker SErvice into constructor rather than instantiating

* fix: export RoleRevokerResolver from claim module
…update_asset_doc

bug/SWTCH-1503 duplicate did
version 912 calls IPFS through /ipfs path on provided url (which is expected ipfs root)
but when this path appended to ipfs gateway it leads to 405
#swtch 1539 

* fix: use arrow function to preserve this context

* fix: format token for formatter check

* fix: use cid
#525)

* fix: perform verification on credentials for enrolment pre-conditions

* fix: remove comments, fix errors

* fix: use injected Issuer Verification Service

* fix: move verification service to role module

* fix: remove comment

* fix: move service to claim module and extract enrolment precondition fetch

* fix: break out logic for checking preconditions and verifying preconditions

* fix: remove unused resolver

* fix: do not remove verifyEnrolmentIssuer

* fix: update claim controller test providers

* fix: perform verification on credentials for enrolment pre-conditions

* fix: remove comments, fix errors

* fix: use injected Issuer Verification Service

* fix: move verification service to role module

* fix: remove comment

* fix: move service to claim module and extract enrolment precondition fetch

* fix: break out logic for checking preconditions and verifying preconditions

* fix: remove unused resolver

* fix: do not remove verifyEnrolmentIssuer

* fix: update claim controller test providers

* fix: provide registry settings to Claim e2e

* fix: add DIDRegistryAddress to test env variables

* fix: pull verification methods out to their own methods

* fix: rename claim controller test to not be e2e

* fix: move verifyDidDocumentContainsEnrolmentPreconditions to claim verif service

* fix: update file name for claim controller test

* test: set up deps for claim service tests

* test: update mock methods

* fix: remove comment

* test: add tests for error scenarios for handleClaimEnrolmentRequest

* test: add test setup for claim verification service

* fix: add optional chaining operator in case undefined

* test: update tests for claim verification

* fix: update claim verification to have Role Credential Resolver be injectable

* fix: only check enrolment preconditions if conditions have role pre-requisites

* fix: update method name

* fix: do not make CredentialResolver injectable

* fix: pull out getCredential method

* fix: remove injectable from role credential resolver

* fix: update test vars

* test: add success case for handleClaimEnrolmentRequest

* fix: remove logs

* fix: use enum for precondition type

* fix: throw error if precondition type is not of type 'role'

* fix: fix expiration test

* fix: make verifyEnrolmentPrerequisites private

* fix: remove duplicative check for type of role

* fix: move duplicative redundant verification to claim verif service

* fix: remove comment

* fix: remove logs and comment

* fix: update mock method name

* test: remove erroneous tests

* test: make methods private and update tests

* test: update error strings and tests to handle errors

* fix: remove undefined check

* fix: add return type

* docs: fix method documentation

* fix: fix spelling error in documentation annotation

* fix: update error return message

* fix: move public method above private methods
What happened is that 2.10 was squash-merged into develop
Therefore the 2.10 commit tag isn't actually on develop branch
This breaks the tag comparison automation
Adding changelog and updating version for 2.11 release
chore(helm): upgrade helm & add JWT sealed secret
@jrhender
Copy link
Collaborator Author

Need to update master-merge branch from develop after #665 is merged.

artursudnik and others added 3 commits September 21, 2023 11:19
* feat: removing package version from the Swagger UI

* fix: fixing `undefined.undefined` version displayed in Swagger UI when executed locally
* chore(staging values): use latest dev image in staging

* ci(build-deploy): don't build new image on master

* chore(staging values): use v2.13 in staging
@jrhender jrhender marked this pull request as ready for review September 22, 2023 15:47
@@ -36,7 +37,7 @@ iam-cache-server-helm:
# runAsUser: 1000

service:
type: NodePort
type: ClusterIP
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timtech4u @vickenliu any concerns with this service type change? Will this work for the ssi-hub staging deployment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so,

Comment on lines +9 to +10
repository: "ghcr.io/energywebfoundation/ssi-hub"
tag: v2.13.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, the staging environment will use this ssi-hub release, instead of building an image from the master branch

@jrhender
Copy link
Collaborator Author

jrhender commented Nov 7, 2023

I checked that no entities are changed, so no database migration is required or expected.

@jrhender jrhender merged commit 6106a9c into master Nov 8, 2023
10 of 11 checks passed
@jrhender jrhender deleted the master-merge branch November 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants