Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest release path calculation should only consider release-shaped locations #158

Open
ess opened this issue Sep 13, 2018 · 0 comments
Open

Latest release path calculation should only consider release-shaped locations #158

ess opened this issue Sep 13, 2018 · 0 comments
Assignees
@ess
Labels
backlog bug

Comments

@ess
Copy link
Contributor

ess commented Sep 13, 2018 •
edited
Loading

Currently, the latest_release path is, effectively, just Dir["/data/appname/releases/*"].last

As we've seen recently, this totally breaks if a non-release item is inadvertently created in the releases directory.

At the least, we should filter for things that match a "probably release directory" regex or something.
@ess ess self-assigned this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ess ess

Labels
backlog bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ess